iox-#308 Remove some magic numbers

[elBoberido]

Pre-Review Checklist for the PR Author

1. [ ] Code follows the coding style of CONTRIBUTING.md
2. [ ] Tests follow the best practice for testing
3. [ ] Changelog updated in the unreleased section including API breaking changes
4. [ ] Branch follows the naming format (iox-#123-this-is-a-branch)
5. [ ] Commits messages are according to this guideline
   • [ ] Commit messages have the issue ID (iox-#123 commit text)
   • [ ] Commit messages are signed (git commit -s)
   • [ ] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. [ ] Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. [ ] Relevant issues are linked
8. [ ] Add sensible notes for the reviewer
9. [ ] All checks have passed (except task-list-completed)
10. [ ] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

• [ ] Commits are properly organized and messages are according to the guideline
• [ ] Code according to our coding style and naming conventions
• [ ] Unit tests have been written for new behavior
  • [ ] Each unit test case has a unique UUID
• [ ] Public API changes are documented via doxygen
• [ ] Copyright owner are updated in the changed files
• [ ] PR title describes the changes

Post-review Checklist for the PR Author

1. [ ] All open points are addressed and tracked via issues

References

• Partly closes #308

[codecov[bot]]

Codecov Report

Merging #1193 (f81985c) into master (259650c) will decrease coverage by 0.06%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1193      +/-   ##
==========================================
- Coverage   79.05%   78.99%   -0.07%     
==========================================
  Files         370      370              
  Lines       14656    14656              
  Branches     2045     2045              
==========================================
- Hits        11587    11577      -10     
- Misses       2399     2407       +8     
- Partials      670      672       +2     

Flag	Coverage Δ
unittests	78.22% <ø> (-0.07%)	:arrow_down:
unittests_timing	13.89% <ø> (-0.01%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
iceoryx_hoofs/source/concurrent/loffli.cpp	82.85% <0.00%> (-8.58%)	:arrow_down:
...fs/include/iceoryx_hoofs/internal/cxx/helplets.inl	93.75% <0.00%> (-2.09%)	:arrow_down:
iceoryx_posh/source/roudi/port_manager.cpp	84.54% <0.00%> (-1.15%)	:arrow_down:

[MatthiasKillat]

@elBoberido I like this solution. It should be fine until we start working with e.g. memory pools for the iceoryx entities (but this is a different concept and more restrictive for the user since the pools may get exhausted and have a restricted memory area).

[elfenpiff]

@elBoberido can this PR be removed since we implemented the heap solution?

[elBoberido]

@elfenpiff I still have some hope that we can make the stack based approach robust. I would keep this open for a few weeks where I can try to fix this for cross-compiling

[elfenpiff]

@elBoberido should we keep this open for the moment or close it and stick to our current solution?

[elBoberido]

@elfenpiff I think we will stick to our current solution. I still have no idea how to solve the cross compiling issue. I'll close this next week if I don't suddenly have an idea

[elBoberido]

@dkroenke do you have some experience with https://cmake.org/cmake/help/latest/prop_tgt/CROSSCOMPILING_EMULATOR.html for running binaries on the emulated target to get artifacts which are used by cmake itself?

[elBoberido]

Closing since cross compiling is hard to solve with this approach