iceoryx icon indicating copy to clipboard operation
iceoryx copied to clipboard

Enums in C-binding are not extendable in a binary compatible and sane way

Open elBoberido opened this issue 2 years ago • 1 comments

Required information

Operating system: all

Compiler version: all

Observed result or behaviour: The enums in the C-binding have an Name_SUCCESS value as last element in the enums. This results in constant ABI breakings when new enum values are added or the Name_SUCCESS value will end somewhere in the middle of the enum

Expected result or behaviour: Enum values can be appended without breaking ABI and without having the Name_SUCCESS somewhere in the middle of the enum

Conditions where it occurred / Performed steps: C-Binding

elBoberido avatar Feb 07 '22 19:02 elBoberido

@elfenpiff what do you think, shall we move all the Name_SUCCESS at the top as first enum value. This has the additional benefit of corresponding to the integer value of 0 which is often used to indicate success

elBoberido avatar Feb 07 '22 19:02 elBoberido