hono icon indicating copy to clipboard operation
hono copied to clipboard

Add ApplicationClient addOnClientReadyHandler()

Open calohmn opened this issue 3 years ago • 4 comments

This is especially needed for the KafkaApplicationClient, letting a given handler be invoked when the Kafka producer is ready. Also introduce a lifecycleStatus in AbstractServiceClient, preventing successive start() invocations.

calohmn avatar Jun 02 '22 05:06 calohmn

@calohmn Are you still working on this? Do you want/need this in 2.0.0?

sophokles73 avatar Jun 08 '22 06:06 sophokles73

@sophokles73 I'm still on it, yes. But I think this should be merged after the 2.0.0 release.

calohmn avatar Jun 08 '22 07:06 calohmn

@calohmn is this ready to be merged?

sophokles73 avatar Jul 13 '22 06:07 sophokles73

@sophokles73 Not yet.

calohmn avatar Jul 13 '22 06:07 calohmn

I've added the lifecycleStatus handling now directly in ProtonBasedApplicationClient in order to implement the added addOnClientReadyHandler method. Changing AbstractServiceClient would have meant a lot more changes.

calohmn avatar Sep 23 '22 14:09 calohmn