Undo/redo is via shortcut is triggers multiple actions

[tortmayr]

Using the keyboard shortcuts for undo/redo results in multiple Undo/Redo actions for one key-stroke.

OS: Linux. Browser: Webkit

[N1k145]

Hey @planger @tortmayr,

we are currently experiencing the same issue with all Key Bindings, like Ctr+H for opening the Eclipse Search. From what I found, this is related to the BrowserKeyBindingForwarderInstaller as the Issue described there is only relevant for Chromium or Edge and not for WebKit. I would propose to add an if windows condition around the registration of this Installer.

I will open a PR soon.

[N1k145]

I did some further investigations, it seems like this is an SWT Issue. When I am using the Eclipse "Internal Web browser" on any generic webpage, I have the same behavior with Ctr+H.

On the GLSP Part, I was somehow able to reduce this issue by disabling the mentioned BrowserKeyBindingForwarderInstaller. But this does not resolve the Issue completely, sometimes the Dialog still opens multiple times. And especially, the Ctrl+Z behavior is still strange and jumps ~3 steps for me, depending on how long you click.

[N1k145]

I created https://github.com/eclipse-platform/eclipse.platform.swt/issues/1200 to report this behavior to SWT as I am able to reproduce this in a plain SWT Webkit Browser without any GLSP specifics

[planger]

@N1k145 Thank you very much for your analysis and for opening the SWT bug! It would be great if we get that resolved. :crossed_fingers: Thanks!