mojarra icon indicating copy to clipboard operation
mojarra copied to clipboard

Published 20 hours ago • verified publisher icon eclipse-ee4j

5.0 Faces Standard Converters with Generics

Open pizzi80 opened this issue 2 years ago • 7 comments
trafficstars

https://github.com/jakartaee/faces/issues/1822

  • Basic Converters with Generics
  • Basic Converters optimized

pizzi80 avatar Sep 05 '23 17:09 pizzi80

@pizzi80 What is the status of this PR?

mnriem avatar Oct 11 '23 21:10 mnriem

The task was finalized on June 22 with the commit https://github.com/eclipse-ee4j/mojarra/pull/5306/commits/6590ff1cbd9c7da5101ce3a6868f1978f48e8a8e.

However, due to numerous merged pull requests in the interim, I had to synchronize my fork, make adjustments to some imports, and alter the name. (last commit)

This was necessitated by the decision of the Faces API community to defer the usage of Generics to Faces 5+

pizzi80 avatar Oct 12 '23 10:10 pizzi80

@pizzi80 So this PR can be closed out?

mnriem avatar Oct 13 '23 11:10 mnriem

If the master is now the version 5.0, I think that it could finally be merged

pizzi80 avatar Oct 13 '23 12:10 pizzi80

@BalusC @arjantijms What do you think?

mnriem avatar Oct 13 '23 21:10 mnriem

@BalusC Thanks for taking the time to review my code ....

I'll fix everything the next week

pizzi80 avatar Oct 14 '23 20:10 pizzi80

During this work I've found that inside the generic NumberConverter

there are some ugly hacks for Java 1.4 and Java 7 that use reflection to invoke some methods that are obviously implemented in Java 8+ ...

Jsf 2.3 is Java 8+, right?

Can I remove the hacks on a separate PR?

pizzi80 avatar Oct 16 '23 15:10 pizzi80

API has been split from Mojarra project into Faces project. Current PR is superseded by https://github.com/jakartaee/faces/pull/1942

BalusC avatar Aug 04 '24 15:08 BalusC