grizzly icon indicating copy to clipboard operation
grizzly copied to clipboard

Grizzly does not build against Servlet 6.1.0-M1

Open lukasj opened this issue 11 months ago • 8 comments

[ERROR] .../org/glassfish/grizzly/servlet/HttpServletResponseImpl.java:[48,8] org.glassfish.grizzly.servlet.HttpServletResponseImpl is not abstract and does not override abstract method sendRedirect(java.lang.String,int,boolean) in jakarta.servlet.http.HttpServletResponse

lukasj avatar Mar 20 '24 20:03 lukasj

@arjantijms nor M2 - both are missing sendRedirect(java.lang.String,int,boolean) method in org.glassfish.grizzly.servlet.HttpServletResponseImpl - in 4.0.2

lukasj avatar Mar 26 '24 16:03 lukasj

@lukasj This commit from a while ago should have fixed that:

https://github.com/eclipse-ee4j/grizzly/pull/2209

arjantijms avatar Jun 24 '24 23:06 arjantijms

You should then try with 4.1.0-M1, not 4.0.2.

arjantijms avatar Jun 24 '24 23:06 arjantijms

that commit went to the main branch and the default one is master. What is the point of having main the master without actually renaming the master to main and keeping both branches? Isn't it confusing?

...to answer the 4.1.0-M1 - yes, this version works fine for me.

lukasj avatar Jun 25 '24 06:06 lukasj

What is the point of having main the master without actually renaming the master to main and keeping both branches? Isn't it confusing?

Still work to be done indeed. It's done now via the self service thing, and I still need to find out where it resides and how it works.

arjantijms avatar Jun 25 '24 21:06 arjantijms

...to answer the 4.1.0-M1 - yes, this version works fine for me.

\o/ thanks!

arjantijms avatar Jun 25 '24 21:06 arjantijms

Also, maybe we need to move Grizzly to the GlassFish project or I need to nominate some other committers. It seems that now I'm the last active committer there.

arjantijms avatar Jun 26 '24 08:06 arjantijms

Also, maybe we need to move Grizzly to the GlassFish project or I need to nominate some other committers. It seems that now I'm the last active committer there.

I can join you, I already did some work on Grizzly: https://github.com/eclipse-ee4j/grizzly/issues?q=author%3Admatej If I remember well, when I was working for Payara I also fixed some h2spec tests. Seems those changes are missing in this repo, I have to check ...

dmatej avatar Jul 06 '24 12:07 dmatej