glassfish icon indicating copy to clipboard operation
glassfish copied to clipboard

Release and integrate updated dependencies

Open dmatej opened this issue 1 year ago • 8 comments
trafficstars

  • Exousia 2.1.2 for GF7
  • Exousia 3.0.0-M3 for GF8
  • Epicyro 3.1.0-M2 for GF8
  • glassfish-build-maven-plugin 4.0.2 for GF7+

dmatej avatar Apr 02 '24 09:04 dmatej

Could glassfish-build-maven-plugin perhaps also be updated to 4.0.1 and integrated? For small Windows build issue: https://github.com/eclipse-ee4j/glassfish-build-maven-plugin/issues/176

escay avatar Apr 04 '24 06:04 escay

Exousia M3 staged: https://jakarta.oss.sonatype.org/content/repositories/staging/org/glassfish/exousia/exousia/3.0.0-M3/

arjantijms avatar Apr 04 '24 13:04 arjantijms

Could glassfish-build-maven-plugin perhaps also be updated to 4.0.1 and integrated?

Yes, sure we can do that

arjantijms avatar Apr 04 '24 13:04 arjantijms

Build plugin 4.0.1 staged: https://jakarta.oss.sonatype.org/content/repositories/staging/org/glassfish/build/glassfishbuild-maven-plugin/4.0.1/

arjantijms avatar Apr 04 '24 14:04 arjantijms

Unfortunately can't integrate it in GF (8) at the moment. The build fails when updating the spec plugin (to 2.2) or the build plugin (to the just staged 4.0.1)

[ERROR] Failed to execute goal org.glassfish.build:glassfishbuild-maven-plugin:4.0.1:featuresets-dependencies (default-featuresets-dependencies) on project glassfish-common: 
Execution default-featuresets-dependencies of goal org.glassfish.build:glassfishbuild-maven-plugin:4.0.1:featuresets-dependencies failed: 
A required class was missing while executing org.glassfish.build:glassfishbuild-maven-plugin:4.0.1:featuresets-dependencies: 
    org/apache/commons/io/build/AbstractStreamBuilder
[ERROR] -----------------------------------------------------
[ERROR] realm =    extension>org.glassfish.build:glassfishbuild-maven-plugin:4.0.1
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] = file:/.m2/repository/org/glassfish/build/glassfishbuild-maven-plugin/4.0.1/glassfishbuild-maven-plugin-4.0.1.jar
[ERROR] urls[1] = file:/.m2/repository/org/apache/maven/maven-archiver/3.6.2/maven-archiver-3.6.2.jar
[ERROR] urls[2] = file:/.m2/repository/org/codehaus/plexus/plexus-archiver/4.9.2/plexus-archiver-4.9.2.jar
[ERROR] urls[3] = file:/.m2/repository/org/codehaus/plexus/plexus-utils/4.0.0/plexus-utils-4.0.0.jar
[ERROR] urls[4] = file:/.m2/repository/org/codehaus/plexus/plexus-io/3.4.2/plexus-io-3.4.2.jar
[ERROR] urls[5] = file:/.m2/repository/org/apache/commons/commons-compress/1.26.1/commons-compress-1.26.1.jar
[ERROR] urls[6] = file:/.m2/repository/org/apache/commons/commons-lang3/3.14.0/commons-lang3-3.14.0.jar
[ERROR] urls[7] = file:/.m2/repository/commons-codec/commons-codec/1.16.1/commons-codec-1.16.1.jar
[ERROR] urls[8] = file:/.m2/repository/org/iq80/snappy/snappy/0.4/snappy-0.4.jar
[ERROR] urls[9] = file:/.m2/repository/org/tukaani/xz/1.9/xz-1.9.jar
[ERROR] urls[10] = file:/.m2/repository/com/github/luben/zstd-jni/1.5.5-11/zstd-jni-1.5.5-11.jar
[ERROR] urls[11] = file:/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.27/plexus-interpolation-1.27.jar
[ERROR] urls[12] = file:/.m2/repository/org/apache/maven/shared/maven-shared-utils/3.4.2/maven-shared-utils-3.4.2.jar
[ERROR] urls[13] = file:/.m2/repository/commons-io/commons-io/2.11.0/commons-io-2.11.0.jar
[ERROR] Number of foreign imports: 1
[ERROR] import: Entry[import  from realm ClassRealm[maven.api, parent: null]]

arjantijms avatar Apr 04 '24 14:04 arjantijms

The following does work:

<plugin>
                    <groupId>org.glassfish.build</groupId>
                    <artifactId>glassfishbuild-maven-plugin</artifactId>
                    <version>4.0.1</version>
                    <!-- Adds support for glassfish-jar and it's customized lifecycle-->
                    <extensions>true</extensions>
                    <dependencies>
                        <dependency>
                            <groupId>commons-io</groupId>
                            <artifactId>commons-io</artifactId>
                            <version>${commons-io.version}</version>
                        </dependency>
                    </dependencies>
                </plugin>

arjantijms avatar Apr 04 '24 14:04 arjantijms

Epicyro M2 staged here: https://jakarta.oss.sonatype.org/content/repositories/staging/org/glassfish/epicyro/epicyro/3.1.0-M2/

arjantijms avatar Apr 04 '24 17:04 arjantijms

The following does work:

<plugin>
                    <groupId>org.glassfish.build</groupId>
                    <artifactId>glassfishbuild-maven-plugin</artifactId>
                    <version>4.0.1</version>
                    <!-- Adds support for glassfish-jar and it's customized lifecycle-->
                    <extensions>true</extensions>
                    <dependencies>
                        <dependency>
                            <groupId>commons-io</groupId>
                            <artifactId>commons-io</artifactId>
                            <version>${commons-io.version}</version>
                        </dependency>
                    </dependencies>
                </plugin>

Then it would be better to just add the dependency to plugin dependencies before the release. In the comment before you have quite old 2.11 for some reason. I will take a look.

EDIT: This is the cause: image

dmatej avatar Apr 12 '24 09:04 dmatej