glassfish icon indicating copy to clipboard operation
glassfish copied to clipboard

Fix the link to the example hello.war

Open libnoon opened this issue 1 year ago • 4 comments

The old link is defunct. Updated the link. Fixed #24801.

libnoon avatar Feb 10 '24 23:02 libnoon

Hmm it looks like the link I suggest as replacement does not contain the same war as the intended one, because the tutorial https://glassfish.org/docs/latest/quick-start-guide.html#deploying-and-undeploying-the-sample-application-from-the-command-line seems to rely on an app which displays a prompt page and responds to it, while the war I'm linking only prints a hello world without interaction.

But then, where is the correct war?

libnoon avatar Feb 10 '24 23:02 libnoon

I would say it should be here, but it really doesn't exist. It probably was on original Oracle website somewhere, then we updated links using regexps, but we still did not validate all targets.

But honestly I don't see any advantage of using a binary file without sources as an example. Perhaps we should rewrite it somehow better.

dmatej avatar Feb 12 '24 07:02 dmatej

I would say all binaries should be here (and in Maven Central too): https://download.eclipse.org/ee4j/glassfish/

dmatej avatar Feb 12 '24 07:02 dmatej

There's a working link on the old GlassFish web site. But I suggest to fix it properly, as I described here: https://github.com/eclipse-ee4j/glassfish/issues/24801#issuecomment-2031707120

OndroMih avatar Apr 02 '24 11:04 OndroMih

It looks like a better fix for this problem has been merged. Closing this PR. Thanks!

libnoon avatar Jun 06 '24 20:06 libnoon