glassfish icon indicating copy to clipboard operation
glassfish copied to clipboard

Missing sources and javadoc Maven artifacts for 7.0.0

Open OndroMih opened this issue 2 years ago • 9 comments

The GlassFish artifacts in Maven Central either don't contain sources and javadoc artifacts or they contain them, but without any relevant content.

GlassFish Full 7.0.0: https://repo1.maven.org/maven2/org/glassfish/main/distributions/glassfish/7.0.0/

  • contains sources JAR, but it's empty, no sources there
  • javadoc JAR is missing

GlassFish Web 7.0.0: https://repo1.maven.org/maven2/org/glassfish/main/distributions/web/7.0.0/

  • same as Full - sources JAR is empty, no javadoc JAR

GlassFish Embedded All: https://repo1.maven.org/maven2/org/glassfish/main/extras/glassfish-embedded-all/7.0.0/

  • contains sources and javadoc JARs, but both are empty

GlassFish Embedded Web: https://repo1.maven.org/maven2/org/glassfish/main/extras/glassfish-embedded-web/7.0.0/

  • same as Embedded All, contains sources and javadoc JARs, but both are empty

This means that no Javadoc is available at javadoc.io, e.g. https://javadoc.io/doc/org.glassfish.main.extras/glassfish-embedded-all Also, no sources can be downloaded by IDEs from Maven.

OndroMih avatar Jan 28 '23 13:01 OndroMih

In Eclipse it works well, because it can see pom.xml and links dependencies. But sure, we can still download and unpack sources of all dependencies and repack them again. I hope I will not see everything twice then :-D

dmatej avatar Jan 28 '23 16:01 dmatej

In Eclipse it works well, because it can see pom.xml and links dependencies. But sure, we can still download and unpack sources of all dependencies and repack them again. I hope I will not see everything twice then :-D

Maybe it works in other IDEs too, I'm not too concerned about sources. But I'd like to fix the javadoc JAR so that it's possible to see javadoc at javadoc.io, and then we could also link to javadocs there from the glassfish.org site.

OndroMih avatar Jan 28 '23 20:01 OndroMih

I am sure that we should not distribute empty jar files - they shouldn't be distributed at all OR they should contain the same as the binary (I mean sources).

dmatej avatar Jan 28 '23 23:01 dmatej

This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment

github-actions[bot] avatar Jan 29 '24 00:01 github-actions[bot]

This is still relevant and hasn't been addressed.

OndroMih avatar Jan 29 '24 00:01 OndroMih

This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment

github-actions[bot] avatar Jan 29 '25 00:01 github-actions[bot]

Hello @OndroMih, do we still need help here?

Ariho-Seth avatar Aug 04 '25 13:08 Ariho-Seth

Hi, @Ariho-Seth, sure, this is still needed. At least javadoc artifacts so that we can publish Javadocs via javadoc.io or similar sites. The sources artifacts are not so important, because when debugging in an IDE, they are usually pulled for specific GlassFish components, which have valid sources and javadoc artifacts.

This would probably require using the javadoc:aggregate goal to assemble javadoc from all dependencies.

Sources might be assembled in a similar way, via source:aggregate, but it's not so important.

OndroMih avatar Aug 04 '25 14:08 OndroMih

Sure thing, I will start on it, though I think I have a problem with my local repo, there is a test that fails, which makes the build fail as discussed here https://github.com/eclipse-ee4j/glassfish/pull/25646#issuecomment-3146777875 Are you facing the same issue?, Any help?

Ariho-Seth avatar Aug 04 '25 14:08 Ariho-Seth