glassfish
glassfish copied to clipboard
Kill Descriptor.boundsChecking
Problem Description
- cargo cult synchronization of it's setter and getter when affected usages are not synchronized. Any change affects all parallel deployments, but as it takes just microseconds, collisions are not happening. Maybe in the year 2030 ;)
- effectively relies on a call of SetMethodAction, nothing else changes the value.
- usages of isBoundsChecking are not just in setters.
Expected Changes
- Just remove it and remove also all related code in dead branches.
- Will throw exceptions if someone would use invalid values in descriptors elements covered by related code. Until now it would tolerate invalid values and just use defaults for some setters, see the image.

Notes (may be expanded later)
- analyze effects of removal in the getType , it switches primitive types to object types if the bounds checking is disabled.
This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment
This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment
This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment