glassfish icon indicating copy to clipboard operation
glassfish copied to clipboard

Refactor com.sun.* classes to org.glassfish.main

Open arjantijms opened this issue 3 years ago • 5 comments

GlassFish uses a mix of org.glassfish and com.sun.* packages. For consistency, and because Eclipse doesn't own com.sun or the domain sun.com it may be better to refactor everything to org.glassfish.*. This may however be quite an operation.

There's also a bunch of technically internal classes exposed in things like domain.xml starting with com.sun.

arjantijms avatar Sep 26 '21 10:09 arjantijms

I agree, but it should be done in some iterative process, because there is pretty much of "magical" reflection. In each iteration we need to pass all available tests (including those obsoleted, TCK, javaee-samples, ... I burned my fingers just with changing names of generated interfaces.

dmatej avatar Sep 27 '21 06:09 dmatej

This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment

github-actions[bot] avatar Sep 28 '22 02:09 github-actions[bot]

I think that the time is close. Just one question: org.glassfish or org.glassfish.main? Because there is many side projects which use org.glassfish too. Or it could be org.glassfish.server. Or org.gf. :-)

dmatej avatar Nov 13 '22 19:11 dmatej

org.glassfish.main probably. Not that it's such a good name, but all the other packages use it.

arjantijms avatar Nov 14 '22 15:11 arjantijms