Respect changes of dialog font

[Godin]

[Godin]

@marchof could you please review?

[marchof]

@Godin Looks like not all labels in the settings dialog adopt the dialog font:

[marchof]

@Godin I remember that I had similar problems to capture all font occurrences.

Same issue for the select buttons in the coverage dialog:

[marchof]

@Godin The session name on our properties page:

[marchof]

@Godin The other dialogs (import, export, merge, select) look good to me though!

[Godin]

@marchof that's strange - I not just added automated tests, but also tested manually by changing font size significantly, however only on Linux, not on Mac.

But never mind - I'll retest/rework. Good catches, thanks!

[Godin]

@marchof this starts to be interesting :laughing:

Manual test on Linux using Eclipse Platform (Version: Oxygen (4.7) Build id: I20160915-0230):

Will try Mac later...

[Godin]

Even simply execution of automated UI test confirms problem on Mac.

[Godin]

According to JavaDoc of Dialog.applyDialogFont

Applies the dialog font to all controls that currently have the default font. Font will also be applied to its children.

so the call is placed correctly at the end.

What driving me crazy - removal of

@@ -138,7 +138,6 @@ public class CoveragePreferencePage extends FieldEditorPreferencePage
   private Group createGroup(final Composite parent, final String text) {
     final Group group = new Group(parent, SWT.NONE);
     group.setText(text);
-    group.setFont(parent.getFont());
     GridDataFactory.fillDefaults().applyTo(group);
     group.setLayoutData(new GridData(GridData.FILL_HORIZONTAL));
     return group;

assuming that this is the place that changes value from default, leads to a really strange result:

[marchof]

@Godin How should we proceed here? Do we apply a "best effort" fix and hope the platform will fix the problem for Mac?

[Godin]

@marchof I still plan to make it work properly on OS X.