fineftp-server icon indicating copy to clipboard operation
fineftp-server copied to clipboard

Support MDTM command

Open Ry-Kode opened this issue 1 year ago • 2 comments

Hello,

First of all a kind thank you for this great library!

Secondly, I was wondering if you are considering to add support for the MDTM command to get the last modified date of a single file?

Thanks again!

Ry-Kode avatar Jul 19 '23 08:07 Ry-Kode

I think that would be a really valuable thing to have. The current implementation is awful (well, actually the specification is awful, the implementation is alright 😀).

Here is the RFC that added MDTM: https://datatracker.ietf.org/doc/html/rfc3659

I don't think that I will have the spare time to add that command any time soon, but PRs are always welcome 😊

Implementation must be added here:

FEAT: https://github.com/eclipse-ecal/fineftp-server/blob/550e502995eb6d6923028132ad7189d418cb03cf/fineftp-server/src/ftp_session.cpp#L1081-L1091

MDTM similar to SIZE: https://github.com/eclipse-ecal/fineftp-server/blob/550e502995eb6d6923028132ad7189d418cb03cf/fineftp-server/src/ftp_session.cpp#L495

FlorianReimold avatar Jul 20 '23 09:07 FlorianReimold

Allright Florian, thanks for the response & the tips on how to implement.

I understand your limited availability, I'm facing the same issue :-) Anyway, if I find a spare moment I'll send you a PR and try to add it.

Ry-Kode avatar Jul 20 '23 13:07 Ry-Kode