ecal icon indicating copy to clipboard operation
ecal copied to clipboard

Feature/measurement api clang warning

Open Kerstin-Keller opened this issue 2 years ago • 1 comments

This PR intends to fix the clang warnings in imeasurement.h/omeasurement.h.

For doing this, another template parameter was introduced, but hidden from the user.

In general, the interface has not changed except for two points:

  • A different file needs to be included, see image
  • The function signature of the Get function for getting a channel from a measurement now has two arguments instead of just one. Happy for any idea on how to solve this! image
  • The message providers are now in the namespace eCAL::message::protobuf, eCAL::message::string. Does it make sense to have it like this, or rather the other way round? (eCAL::protobuf::message, eCAL::string::message)....

Kerstin-Keller avatar May 24 '22 07:05 Kerstin-Keller

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 24 '22 08:05 github-actions[bot]