ditto icon indicating copy to clipboard operation
ditto copied to clipboard

Change return type of `JsonValue.of` to `JsonNumber` for number arguments

Open jufickel-b opened this issue 3 years ago • 3 comments

Currently all variants of JsonValue.of return a JsonValue. For number arguments, however, it is desirable to obtain a JsonNumber without being forced to manually cast. As JsonNumber extends JsonValue, changing the method signatures would be a low hanging fruit that improves ditto-json API a bit.

jufickel-b avatar May 21 '21 14:05 jufickel-b

Additionally it is worth to think about introducing a JsonFieldDefinition for JsonNumber.

jufickel-b avatar May 21 '21 15:05 jufickel-b

@jufickel-b Hi I am an open source enthusiast who contributes to java projects and previous google summer of code student developer, I am looking for new challenge so can you please tell me if I can contribute here?

theexplorist avatar Aug 10 '21 18:08 theexplorist

Hi @theexplorist, thanks for reaching out to us. Of course you can contribute here. Before doing so, it is crucial that you have a look at CONTRIBUTING.md – especially the legal requirements.

jufickel-b avatar Aug 11 '21 10:08 jufickel-b