cyclonedds-python icon indicating copy to clipboard operation
cyclonedds-python copied to clipboard

Solving IDL generator with structs inheritance which identifiers are Python keywords

Open Bit-Seq opened this issue 2 years ago • 6 comments
trafficstars

Solved the error detailed on #173.

Bit-Seq avatar Nov 29 '22 15:11 Bit-Seq

Thanks @Bit-Seq! I think this change is okay, we are just having some CI troubles right now. I'll rerun when that is resolved and come back to this PR.

thijsmie avatar Nov 29 '22 16:11 thijsmie

Struct inheritance tests are in https://github.com/javiersorianoruiz/cyclonedds-python-checkReservedKeyword/tree/master/tests/. All the 007_test_X are related to it.

Bit-Seq avatar Nov 29 '22 17:11 Bit-Seq

Hello!

Have you been able to solve CI troubles?

We (@jordialexalar and me) have created tests related to reserved Python keywords support using pytest. For a mistake we have added this file in the same fork as the pull requests pending to merge. All pull requests are connected, and also with the issues #105, #162, #163, #172 and #173.

Sorry for the inconvenience. If there is any problem we can create another fork and pull request with the tests.

Regards.

Bit-Seq avatar Dec 14 '22 10:12 Bit-Seq

Hi @Bit-Seq,

Yeah I did but the PR has not been reviewed yet (see #176). As soon as that is merged rerunning this should also succeed.

thijsmie avatar Dec 14 '22 11:12 thijsmie

I was discussing the status of this PR with @NoxPardalis and triggered a custom run of the CI for this PR to confirm that all is well with #176 merged, but it turns out there is some problem: https://dev.azure.com/eclipse-cyclonedds/cyclonedds-python/_build/results?buildId=3867&view=results . The results of this run are not visible on GitHub because, well, reasons, but if I am not mistaken I started it the right way.

I haven't looked at all the failures, but my sample suggests it consistently fails in the test_datatypes_keywords tests. I haven't dug into it (too many things to do, too little time ...), but would you perchance have some time to look into it, @Bit-Seq ?

On a side note: if the test run were successful, merging it would still be blocked anyway on the Eclipse Contributor Agreement verification.

eboasson avatar Jan 26 '23 07:01 eboasson

Cat on keyboard 😂

eboasson avatar Feb 17 '23 17:02 eboasson