che
che copied to clipboard
eclipse-che
Improve a behavior when try to commit changes for a public repository factory without PAT/OAuth setup
Is your enhancement related to a problem? Please describe
When try to commit changes for launched factory from a public repository without any PAT/OAuth setup, is appeared the dialog error box, that looks not user friendly and correct.
Describe the solution you'd like
I think, it should work differently, firstly, to avoid an appearing this error dialog box. Then, may be, allow to commit with some default values.
I would also think about Push changes is allowed operation for this case or not, it's possible, this is theme of a separate issue.
Also take a look on the fact, that the Gitconfig is empty in the UserPreferences, what is not correct, it seems.
Describe alternatives you've considered
No response
Additional context
No response
@azatsarynnyy @RomanNikitenko @l0rd wondering if it would be technically possible to customize the poup and a add a link that redirects to /dashboard/#/user-preferences?tab=gitconfig that would allow user to setup username / email
I'm not a huge fan of the placeholder approach of creating default .gitconfig with a dummy name / email to be honest
It shouldn't be hard to customize this dialog: https://github.com/che-incubator/che-code/blob/1eacbf59f30a4d628e5909f231c18a7293a37cbb/code/extensions/git/src/commands.ts#L3782-L3783
@ibuziuk @azatsarynnyy
Does it mean, this issue can be reassigned to team/B and it will be planned to resolve ?
My question is related to this issue, because two E2E UI tests are failing and their fix up depends on a solution of the current issue.
I've changed labels according to the solution described in the https://github.com/eclipse-che/che/issues/22603#issuecomment-1838613599
