che icon indicating copy to clipboard operation
che copied to clipboard

`che-editor` URL parameter should have higher priority than `.che/che-editor.yaml`

Open l0rd opened this issue 3 years ago • 0 comments

Describe the bug

If I specify che-editor URL parameter I expect it to have higher priority compared to the editor specified in the git repository .che/che-editor.yaml.

Che version

next (development version)

Steps to reproduce

Start a workspace specifying the che-editor URL parameter using a git repository that contains a .che/che-editor.yaml.

For example, using the dogfooding Che instance, a repository that has a .che/che-editor.yaml where che-code is specified and the parameter che-editor=eclipse/che-theia/next:

https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/#https://github.com/l0rd/tilt-example-java/?che-editor=eclipse/che-theia/next

Expected behavior

The editor specified in the URL parameter should be used, not the one in the .che/che-editor.yaml file.

Runtime

OpenShift

Screenshots

No response

Installation method

chectl/next

Environment

Amazon

Eclipse Che Logs

No response

Additional context

No response

l0rd avatar Jul 19 '22 15:07 l0rd

I've tried the provided factory link https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/#https://github.com/l0rd/tilt-example-java/?che-editor=eclipse/che-theia/next. For me, it spinned up a Che-Theia-based workspace. At first sight, it looks like expected behavior. But actually, it works like that because the content of the .che/che-editor.yaml file is ignored. I've described that problem in https://github.com/eclipse/che/issues/21639

azatsarynnyy avatar Aug 17 '22 14:08 azatsarynnyy