che-server
che-server copied to clipboard
Throw an error if Devfile from unsupported ssh repository is not resolved
What does this PR do?
Throw an error if Devfile from unsupported ssh repository is not resolved instead of returning an empty factory dto without devfile. The ApiException
will be handled by dashboard and default devfile will be used: https://github.com/eclipse-che/che-dashboard/blob/05bf4383a45cb367924c788763beb5c7689a7c79/packages/dashboard-frontend/src/components/WorkspaceProgress/CreatingSteps/Fetch/Devfile/index.tsx#L215
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://github.com/eclipse-che/che/issues/23277
How to test this PR?
- Deploy che with the pull request image:
quay.io/eclipse/che-server:pr-763
- Start workspcae from an ssh url of an unsupported provider e.g.
[email protected]:ivinokur/test.git
See workspace starts from the default devfile.
PR Checklist
As the author of this Pull Request I made sure that:
- [ ] The Eclipse Contributor Agreement is valid
- [ ] Code produced is complete
- [ ] Code builds without errors
- [ ] Tests are covering the bugfix
- [ ] The repository devfile is up to date and works
- [ ] Sections
What issues does this PR fix or reference
andHow to test this PR
completed - [ ] Relevant user documentation updated
- [ ] Relevant contributing documentation updated
- [ ] CI/CD changes implemented, documented and communicated
Release Notes
Reviewers
Reviewers, please comment how you tested the PR when approving it.