che-server icon indicating copy to clipboard operation
che-server copied to clipboard

Throw an error if Devfile from unsupported ssh repository is not resolved

Open vinokurig opened this issue 1 week ago • 8 comments

What does this PR do?

Throw an error if Devfile from unsupported ssh repository is not resolved instead of returning an empty factory dto without devfile. The ApiException will be handled by dashboard and default devfile will be used: https://github.com/eclipse-che/che-dashboard/blob/05bf4383a45cb367924c788763beb5c7689a7c79/packages/dashboard-frontend/src/components/WorkspaceProgress/CreatingSteps/Fetch/Devfile/index.tsx#L215

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://github.com/eclipse-che/che/issues/23277

How to test this PR?

  1. Deploy che with the pull request image: quay.io/eclipse/che-server:pr-763
  2. Start workspcae from an ssh url of an unsupported provider e.g. [email protected]:ivinokur/test.git

See workspace starts from the default devfile.

PR Checklist

As the author of this Pull Request I made sure that:

Release Notes

Reviewers

Reviewers, please comment how you tested the PR when approving it.

vinokurig avatar Feb 13 '25 14:02 vinokurig