che-server
che-server copied to clipboard
eclipse-che
chore: switch to default editor = che-incubator/che-code/latest
What does this PR do?
chore: switch to default editor = che-incubator/che-code/latest (CRW-3099, CRW-3420, https://github.com/eclipse/che/issues/20500)
Change-Id: Ib576241488e9ada5465dd45a9bc140cd6b4ed7e6 Signed-off-by: Nick Boldt [email protected]
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-3099, https://issues.redhat.com/browse/CRW-3420, https://github.com/eclipse/che/issues/20500
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
- [x] The Eclipse Contributor Agreement is valid
- [x] Code produced is complete
- [x] Code builds without errors
- [ ] Tests are covering the bugfix
- [x] The repository devfile is up to date and works, if one exists
- [x] Sections What issues does this PR fix or reference and How to test this PR completed
- [x] Relevant user documentation updated
- [x] Relevant contributing documentation updated
- [x] CI/CD changes implemented, documented and communicated
Reviewers
Reviewers, please comment how you tested the PR when approving it.
how was it tested?
Other than the automated checks, it was not manually tested.
I don't know why @MichalMaler and @themr0c are marked as reviewers: you can safely remove us from the reviewer list. If you need docs team reviewers, it should rather be: @rkratky, @max-cx, @deerskindoll and @osslate.
@ibuziuk so should we merge this or wait until 7.62 / 3.6 when we're removing theia entirely...?
@themr0c:
I don't know why @MichalMaler and @themr0c are marked as reviewers: you can safely remove us from the reviewer list. If you need docs team reviewers, it should rather be: @rkratky, @max-cx, @deerskindoll and @osslate.
See https://github.com/eclipse-che/che-server/pull/434 - in which I'm removing and simplifying the CODEOWNERS to exclude people who shouldn't be there anymore.
You were in there previously because the che.properties file is pseudo-doc and directly affects the che docs + downstream docs too.
I am not sure what's your purpose @nickboldt but the default editor is specified here. These properties are not used anymore.
