chore: Update GitHub actions to use Node 16 and Ubuntu Latest

[SDawley]

Signed-off-by: sdawley [email protected]

What does this PR do?

Update GitHub actions to use Node 16 and Ubuntu Latest

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://github.com/eclipse/che/issues/21763

How to test this PR?

Run GH Actions to make sure they still work properly.

PR Checklist

As the author of this Pull Request I made sure that:

• [ ] The Eclipse Contributor Agreement is valid
• [ ] Code produced is complete
• [ ] Code builds without errors
• [ ] Tests are covering the bugfix
• [ ] The repository devfile is up to date and works
• [ ] Sections What issues does this PR fix or reference and How to test this PR completed
• [ ] Relevant user documentation updated
• [ ] Relevant contributing documentation updated
• [ ] CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[openshift-ci[bot]]

Hi @SDawley. Thanks for your PR.

I'm waiting for a eclipse-che member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions[bot]]

Click here to review and test in web IDE:

[codecov[bot]]

Codecov Report

Merging #1506 (fca1e26) into main (1321bde) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1506   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files          47       47           
  Lines        1445     1445           
  Branches      247      247           
=======================================
  Hits         1353     1353           
  Misses         92       92           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[svor]

@SDawley please fix shellcheck GH action's failures https://github.com/eclipse-che/che-plugin-registry/actions/runs/3652981131/jobs/6179520892

[nickboldt]

@SDawley please fix shellcheck GH action's failures https://github.com/eclipse-che/che-plugin-registry/actions/runs/3652981131/jobs/6179520892

To be fair, this PR is for yaml files, not bash files... do we really need a passing shellcheck for yaml? :D Maybe a second PR would be better for that...

[github-actions[bot]]

Click here to review and test in web IDE:

[svor]

To be fair, this PR is for yaml files, not bash files... do we really need a passing shellcheck for yaml? :D Maybe a second PR would be better for that...

yes, but before these changes shellcheck PR check was passed without errors (see previous PRs), probably because of https://github.com/eclipse-che/che-plugin-registry/pull/1506/files#diff-3c73f64339a28ea5cd74f18201c12edf164e925b8816dbacd64c0116c6671399R16

I'm OK to have the fix for ShellCheck in another PR, but let's revert changes in shellcheck-pr-check.yml in this PR

[github-actions[bot]]

Click here to review and test in web IDE:

[SDawley]

I reverted shellcheck to Ubuntu 20.04 and it works now, though we should figure out why it breaks on 22.04.

[github-actions[bot]]

Click here to review and test in web IDE:

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SDawley, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment