che-operator
che-operator copied to clipboard
Chore: CRW-4043 Improve process for building midstream and syncing to downstream
What does this PR do?
Add build/dockerfiles/brew.Dockerfile. Move Dockerfile to build/dockerfiles. Update Makefile and git actions to reflect new location.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-4043
How to test this PR?
cat > /tmp/patch.yaml <<EOF
<PATCH_CONTENT>
EOF
chectl server:deploy \
--installer operator \
--platform <PLATFORM_TO_DEPLOY> \
--che-operator-image <CUSTOM_OPERATOR_IMAGE> \
--che-operator-cr-patch-yaml /tmp/patch.yaml
PR Checklist
As the author of this Pull Request I made sure that:
- [ ] The Eclipse Contributor Agreement is valid
- [ ] Code produced is complete
- [ ] Code builds without errors
- [ ] Tests are covering the bugfix
- [ ] Development resource are up to date
- [ ] The repository devfile is up to date and works
- [ ] Sections
What issues does this PR fix or referenceandHow to test this PRcompleted - [ ] Relevant user documentation updated
- [ ] Relevant contributing documentation updated
- [ ] CI/CD changes implemented, documented and communicated
Reviewers
Reviewers, please comment how you tested the PR when approving it.
We have to update and check test-catalog-from-sources.sh:
https://github.com/eclipse-che/che-operator/blob/2182f45ae98daaee7ef29fd42d6f8144f1717925/build/scripts/olm/test-catalog-from-sources.sh#L95
@SDawley please, rebase on main branch
/retest
Codecov Report
Merging #1638 (ef1391b) into main (7207630) will increase coverage by
0.31%. The diff coverage is92.85%.
@@ Coverage Diff @@
## main #1638 +/- ##
==========================================
+ Coverage 58.38% 58.70% +0.31%
==========================================
Files 72 72
Lines 8358 8335 -23
==========================================
+ Hits 4880 4893 +13
+ Misses 3150 3113 -37
- Partials 328 329 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/deploy/sync.go | 65.86% <ø> (-3.33%) |
:arrow_down: |
| pkg/deploy/tls/certificates.go | 79.38% <92.85%> (+25.71%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@tolusha I rebased and all tests have passed. Did I forget anything?
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: SDawley, tolusha
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@SDawley pls, resolve the conflict.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@SDawley: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/v14-devworkspace-happy-path | ef1391b62d30f34653babdeb2cf6862d87e30e1c | link | true | /test v14-devworkspace-happy-path |
| ci/prow/v14-che-behind-proxy | ef1391b62d30f34653babdeb2cf6862d87e30e1c | link | true | /test v14-che-behind-proxy |
| ci/prow/v14-operator-test | ef1391b62d30f34653babdeb2cf6862d87e30e1c | link | true | /test v14-operator-test |
| ci/prow/v14-upgrade-stable-to-next | ef1391b62d30f34653babdeb2cf6862d87e30e1c | link | true | /test v14-upgrade-stable-to-next |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.