che-operator icon indicating copy to clipboard operation
che-operator copied to clipboard

Chore: CRW-4043 Improve process for building midstream and syncing to downstream

Open SDawley opened this issue 2 years ago • 9 comments

What does this PR do?

Add build/dockerfiles/brew.Dockerfile. Move Dockerfile to build/dockerfiles. Update Makefile and git actions to reflect new location.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-4043

How to test this PR?

cat > /tmp/patch.yaml <<EOF
<PATCH_CONTENT>
EOF

chectl server:deploy \
     --installer operator \
     --platform <PLATFORM_TO_DEPLOY> \
     --che-operator-image <CUSTOM_OPERATOR_IMAGE> \
     --che-operator-cr-patch-yaml /tmp/patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

SDawley avatar Mar 11 '23 01:03 SDawley

We have to update and check test-catalog-from-sources.sh:

https://github.com/eclipse-che/che-operator/blob/2182f45ae98daaee7ef29fd42d6f8144f1717925/build/scripts/olm/test-catalog-from-sources.sh#L95

tolusha avatar Mar 15 '23 09:03 tolusha

@SDawley please, rebase on main branch

tolusha avatar Mar 30 '23 05:03 tolusha

/retest

SDawley avatar Mar 30 '23 15:03 SDawley

Codecov Report

Merging #1638 (ef1391b) into main (7207630) will increase coverage by 0.31%. The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main    #1638      +/-   ##
==========================================
+ Coverage   58.38%   58.70%   +0.31%     
==========================================
  Files          72       72              
  Lines        8358     8335      -23     
==========================================
+ Hits         4880     4893      +13     
+ Misses       3150     3113      -37     
- Partials      328      329       +1     
Impacted Files Coverage Δ
pkg/deploy/sync.go 65.86% <ø> (-3.33%) :arrow_down:
pkg/deploy/tls/certificates.go 79.38% <92.85%> (+25.71%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Mar 30 '23 16:03 codecov[bot]

@tolusha I rebased and all tests have passed. Did I forget anything?

SDawley avatar Mar 31 '23 16:03 SDawley

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SDawley, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 03 '23 06:04 openshift-ci[bot]

@SDawley pls, resolve the conflict.

tolusha avatar Apr 05 '23 07:04 tolusha

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Apr 05 '23 11:04 openshift-merge-robot

@SDawley: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-devworkspace-happy-path ef1391b62d30f34653babdeb2cf6862d87e30e1c link true /test v14-devworkspace-happy-path
ci/prow/v14-che-behind-proxy ef1391b62d30f34653babdeb2cf6862d87e30e1c link true /test v14-che-behind-proxy
ci/prow/v14-operator-test ef1391b62d30f34653babdeb2cf6862d87e30e1c link true /test v14-operator-test
ci/prow/v14-upgrade-stable-to-next ef1391b62d30f34653babdeb2cf6862d87e30e1c link true /test v14-upgrade-stable-to-next

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jan 15 '24 18:01 openshift-ci[bot]