packagedrone icon indicating copy to clipboard operation
packagedrone copied to clipboard

Published 20 hours ago • verified publisher icon eclipse-archived

Update RpmInputStream.java

Open ghost opened this issue 6 years ago • 1 comments

Removed many calls to ensureInit by placing it in the constructor.

ghost avatar Oct 31 '19 13:10 ghost

Hi @krustocious27 Thank you for the PR. First of all, the RPM code moved on to the Eclipse Packager project (https://projects.eclipse.org/projects/technology.packager) … I know I have to make this more transparent.

However I also see a technical problem with your PR. Yes, there are now less calls to the "ensureInit" method, but would it leak streams in case of an exception.

Assume your are doing something like try ( x = new RpmInputStream(s) { … }. My expectation would be, that the close method gets called at the end of the block, and s gets closed. However in the changed behavior, the constructor of RpmInputStream would fail, and not call the close method and s might be leaked.

ctron avatar Nov 06 '19 08:11 ctron