kiso icon indicating copy to clipboard operation
kiso copied to clipboard

Refactor BCDS_Queue to Kiso_Queue

Open HansUweRempler opened this issue 5 years ago • 4 comments

Issue by sebastianpfischer Friday Jun 28, 2019 at 09:22 GMT Originally opened as https://github.com/Bosch-AE-SW/cddk-oss/issues/120


Reasons:

  • unittest failing on linux 64bit machine due to misalignments in the current implementation.
  • -> Basically the module has a dependency on the type of machines --> Issue for compatibilities

Todo:

  • ~Use instead the stream-buffer of freeRTOS to fulfil the same needs.~
  • Refactoring discussed with @ChiefGokhlayehBosch to fit the Cellular requirements. See picture

HansUweRempler avatar Jan 17 '20 10:01 HansUweRempler

Comment by bierkandt-bosch Wednesday Jul 31, 2019 at 07:17 GMT


  • Code written and manually tested
  • Open:
    • Add unit tests
    • Need to verify it works with cellular

HansUweRempler avatar Jan 17 '20 10:01 HansUweRempler

Comment by bierkandt-bosch Thursday Sep 05, 2019 at 08:55 GMT


Discussion during daily:

  • Cellular is using the old queue
  • Old queue does not have unit tests
  • Old queue does not work with C++
  • Ideally remove old queue and use new queue for ICD => to be decided during planning today

HansUweRempler avatar Jan 17 '20 10:01 HansUweRempler

Comment by bierkandt-bosch Thursday Sep 05, 2019 at 12:13 GMT


Decision during planning:

  • for now put the old queue into cellular (protected), thus an "cellular internal tool" and cannot be used outside of cellular
  • use the time to finalize new queue then publish under utils
  • refactor cellular to use the new queue

HansUweRempler avatar Jan 17 '20 10:01 HansUweRempler

Comment by ChiefGokhlayehBosch Thursday Sep 12, 2019 at 13:33 GMT


  • [x] refactor cellular to use the new queue

PR in review.

HansUweRempler avatar Jan 17 '20 10:01 HansUweRempler