kiso icon indicating copy to clipboard operation
kiso copied to clipboard

XProtocol with dataLength >= 0xFFFF

Open HansUweRempler opened this issue 5 years ago • 2 comments

Issue by amushatov Friday Oct 18, 2019 at 13:43 GMT Originally opened as https://github.com/Bosch-AE-SW/cddk-oss/issues/347


XProtocol_EncodeFrame() and XProtocol_DecodeFrame() currently have hidden limitation (not handled at all) for dataLength because of param type of CRC_16(). However it looks like CRC_16() can be called in loop over bigger buffer with smaller chunks. Must be checked again.

Additional findings with XProtocol:

  1. XProtocol_IsCompleteFrame() param lastCheckPosition is useless and can be removed.
  2. Will be good to have mechanism (function) to calculate required length for encoded buffer.

HansUweRempler avatar Jan 17 '20 10:01 HansUweRempler

Comment by HansUweRempler Sunday Nov 17, 2019 at 09:50 GMT


@amushatov I assume this is part of the Kiso SW module "Utils" or "Essentials". Thus, I labeled the issue with "Epic: Core". Please let me know if this is not correct.

HansUweRempler avatar Jan 17 '20 10:01 HansUweRempler

Comment by amushatov Thursday Jan 16, 2020 at 13:33 GMT


It is part of core/utils, so "Epic: Core" is ok.

HansUweRempler avatar Jan 17 '20 10:01 HansUweRempler