antenna icon indicating copy to clipboard operation
antenna copied to clipboard

JS Coordinates get rendered like maven coordinates, which is unexpected

Open maxhbr opened this issue 5 years ago • 0 comments

The following code renders a wrong toString representation for JS Coordinates https://github.com/eclipse/antenna/blob/ffab29d60656ef8a9ea7d5aaa68f9846248666ad/core/model/src/main/java/org/eclipse/sw360/antenna/model/artifact/facts/javaScript/JavaScriptCoordinates.java#L81-L87

I would expect something like the following, which matches my expectation of the string representation of JS Coordinates:

    public String toString() {
        if (namespace == null) {
            return packageName + "-" + version;
        } else {
            return namespace + "/" + packageName + "-" + version;
        }
    }

Definition of Done

  • [ ] Acceptance criteria fulfilled
  • [ ] A test case is created to reproduce the bug
  • [ ] A PR is created, the CI infrastructure reports green, the bug test case proves that bug is fixed
  • [ ] The PR is reviewed and approved
  • [ ] No TODOs left in the code unless explained in the ticket, if something else is still open, this is summarized in a comment in the issue
  • [ ] Documentation is updated

maxhbr avatar Oct 16 '19 09:10 maxhbr