zxing.rb icon indicating copy to clipboard operation
zxing.rb copied to clipboard

Published 20 hours ago • verified publisher icon ecin

add new method qrcode_decode

Open hanpeic opened this issue 7 years ago • 3 comments

updated jar file version improve QR code decode ability same as the website: zxing.org

hanpeic avatar May 26 '17 08:05 hanpeic

Thanks for your PR! Will review shortly. 😄

ecin avatar May 26 '17 18:05 ecin

@hanpeic can you add a description that explains how this code works, and why it's needed?

By the way, thanks for adding so many fixtures to the code!

ecin avatar May 26 '17 20:05 ecin

Hi @ecin thanks for your quick reply. When I call this gem to parse QR code, I find some QR code parse failed, but if I upload to zxing.org, it could get the result. After I checked the source code of zxing.org, the key point is this line: https://github.com/zxing/zxing/blob/master/zxingorg/src/main/java/com/google/zxing/web/DecodeServlet.java#L367

It tries 'HybridBinarizer' to parse again if first time failed. so I add same code in this gem. to make sure if a QR code could parse by zxing.org, then It could parse by this gem too.

hanpeic avatar May 26 '17 23:05 hanpeic