mongoose-geojson-schema icon indicating copy to clipboard operation
mongoose-geojson-schema copied to clipboard

Passing NaN as point coordinates should fail

Open kjeremy opened this issue 7 years ago • 6 comments

This:

var pointData = {
        type: 'Point',
        coordinates: [NaN, NaN]
    };

passes the range checks but it shouldn't.

kjeremy avatar Jul 18 '18 15:07 kjeremy

@kjeremy: Please contribute a pull request which confirms this case. See an example similar test here: https://github.com/RideAmigosCorp/mongoose-geojson-schema/blob/master/test/GeoJSON.integration.js#L111

markstos avatar Jul 18 '18 16:07 markstos

@markstos @kjeremy I added in a test for this on the master branch. Can you check?

joshkopecek avatar Jul 19 '18 09:07 joshkopecek

@joshkopecek Looks good to me. I also see an unrelated warning that the node-growl dependency should be updated due to a security issue.

markstos avatar Jul 19 '18 13:07 markstos

LGTM

kjeremy avatar Jul 19 '18 14:07 kjeremy

I pushed two commits to master which removes the unused supertest dep, which was generating a security warning.

I also updated "mocha", because one of it's deps had a security warning as well.

Releasing soon is not important, as neither dep update affects live code.

markstos avatar Jul 24 '18 18:07 markstos

@markstos I've pushed an update, tagged v2.1.3

  • Updating mongoose devdep to 5
  • Removing gulp (only used it for jshint and mocha anyway)
  • Fix the local mongoose to use a standard connection string
  • Update mocha to manually exit when done

joshkopecek avatar Jul 25 '18 08:07 joshkopecek