ilda.rs icon indicating copy to clipboard operation
ilda.rs copied to clipboard

Animation returns an empty trailing Frame

Open lukasjapan opened this issue 5 years ago • 1 comments

A trailing frame with no points is returned by the Animation parser.


https://github.com/echelon/ilda.rs/blob/master/src/animation.rs#L116

The ILDA specification defines an empty header at the end of the file which is transformed into a Frame by the above implementation.

IMO this header should behave like an EOF marker and should be discarded. Introducing an additional frame might lead to unwanted side effects.

lukasjapan avatar May 06 '19 09:05 lukasjapan

Thanks for filing this! I've been needing some proper code review.

I'll get to this shortly.

echelon avatar May 07 '19 06:05 echelon