Add support for highlight groups of listed plugins

[231tr0n]

Contributing guidelines

• [X] I have read CONTRIBUTING.md
• [X] I have read CODE_OF_CONDUCT.md

Module(s)

mini.hues, mini.base16

Description

Hii echasnovski! Can the following plugin highlights be supported by mini.hues and mini.base16 if possible. https://github.com/OXY2DEV/helpview.nvim https://github.com/MeanderingProgrammer/render-markdown.nvim https://github.com/OXY2DEV/markview.nvim https://github.com/ibhagwan/fzf-lua https://github.com/folke/trouble.nvim - new v4 rewrite adds new highlights

[echasnovski]

Thanks for the suggestion!

Those are fairly new plugins, so I'd rather wait until highlight group names are fairly stable.

In the meantime, what highlights do you miss when applied 'mini.hues' or 'mini.base16'?

[231tr0n]

I use onedark base16 color palette and the output for render-markdown.nvim looks something of this sort:- The output for helpview.nvim looks like this I mean the colors dont blend well in the case of helpview.nvim and they blend way too much in the case of render-markdown.nvim

[231tr0n]

Thanks for the suggestion!

Those are fairly new plugins, so I'd rather wait until highlight group names are fairly stable.

In the meantime, what highlights do you miss when applied 'mini.hues' or 'mini.base16'?

What you said makes sense but if possible and if it might not be a huge task can you please consider supporting render-markdown.nvim. helpview.nvim makes sense since it is newer.

[231tr0n]

Hi! I also added fzf-lua and trouble.nvim. Trouble.nvim v4 had a big rewrite recently and a lot of new highlight groups have been added.

[echasnovski]

Hi! I also added fzf-lua and trouble.nvim. Trouble.nvim v4 had a big rewrite recently and a lot of new highlight groups have been added.

What exactly you think is missing from 'folke/trouble.nvim' (which is already supported) and 'ibhagwan/fzf-lua' (which looks fine the last time I checked)?

[231tr0n]

Hi! I also added fzf-lua and trouble.nvim. Trouble.nvim v4 had a big rewrite recently and a lot of new highlight groups have been added.

What exactly you think is missing from 'folke/trouble.nvim' (which is already supported) and 'ibhagwan/fzf-lua' (which looks fine the last time I checked)?

Hi! So the new trouble v4 with mini.base16 colorscheme and one dark color palette looks something like below. The icons are not properly shown:-

As per fzf-lua, there is no coloring in lsp_document_symbols and lsp_workspace_symbols. There seems to be coloring for fzf-lua when using tokyonight.nvim.

[bassamsdata]

I believe this plugin render-markdown is well-established, given that it's been in development for over three months and has made its way into the default plugins of the LazyVim distro.

I use it daily with base16 module.

[echasnovski]

Thanks for the insight! I am afraid, both of these observations are not enough for me. Besides, "made its way into the default plugins of the LazyVim distro" is at least not accurate, as it is part of "Extra" for markdown language and is not "default" (which are arguably the ones included by default, i.e. 'mini.ai', 'mini.pairs', 'folke/lazy.nvim', 'folke/which-key.nvim', etc.).

[bassamsdata]

Thanks for the insight! I am afraid, both of these observations are not enough for me.

No worries at all.

as it is part of "Extra" for markdown language and is not "default"

That’s correct, it’s the default within the markdown language bundle under "Extra."

I apply those highlights every time I change themes, so it works just fine for me.

Cheers!

[echasnovski]

This should be resolved on latest main.

@231tr0n, regarding 'fzf-lua' and 'trouble.nvim' issues from this comment:

• There doesn't seem to be a way to add colors to that part of lsp_document_symbols / lsp_workspace_symbols pickers.
• I didn't observe the issue with 'trouble.nvim' and icons.

[231tr0n]

This should be resolved on latest main.

@231tr0n, regarding 'fzf-lua' and 'trouble.nvim' issues from this comment:

* There doesn't seem to be a way to add colors to that part of `lsp_document_symbols` / `lsp_workspace_symbols` pickers.

* I didn't observe the issue with 'trouble.nvim' and icons.

I stopped using them because of your juicy and delicious mini.pick module which can list both diagnostics and do what all fzf-lua can mostly. Also to add to the fact I am not dealing with those big json files anymore so mini.pick does the job perfectly for me.