Evgeni Chasnovski
Evgeni Chasnovski
@justinmk, [there are issues with this](https://github.com/neovim/neovim/pull/29428#issuecomment-2180222641). If this type of functionality is useful, exporting [this type of Insert mode mapping](https://github.com/neovim/neovim/pull/29428#issuecomment-2180369913) is a more versatile approach.
> > Even if comment marks are verbose, ability to add them in Insert mode looks more ergonomic > > I don't get this argument. Textobjects are the primary text...
> well then we couldn't add any new builtin mappings? Of course adding built-in mappings is possible. But having `igc` as Operator-pending mode mapping in particular means that users will...
> Yes, that's true for multiple singleline comments following each other. However, it's something that could be fixed if this behaviour is desired. As built-in commenting is designed to be...
> @echasnovski what's your take on this? What are your requirements to add new icons to `mini.icons` vs leaving it up to the user to configure? I am leaning on...
There are now [documented criteria in each category](https://github.com/echasnovski/mini.nvim/blob/45b3540003566e8f19c4cc4b1c9d0b8605a2697c/doc/mini-icons.txt#L267) for an icon to be considered for adding to built-ins. TL;DR: basically what is listed in previous comment. I plan to add...
Some of the filetypes from this PR were added to 'mini.icons'. Here is [the commit](https://github.com/echasnovski/mini.nvim/commit/12d275f4c3aeddfa12a758a69aff65090613ca34). Some notes: - 'tf' filetype doesn't seem to be for terraform, but for something called...
> The new `NEWS` icon however is currently the same as for changelog. This was deliberate as 'NEWS.md' and 'CHANGELOG.md' seem to be used interchangeably. But I am open to...
> I noticed you didn't include any of the javascript/typescript ecosystem icons, while those are wildly used. Is there a reason for this? Most of those icons are the exact...
It is [`MiniIconsGrey`](https://github.com/echasnovski/mini.nvim/blob/12d275f4c3aeddfa12a758a69aff65090613ca34/lua/mini/icons.lua#L139), not `MiniIconsGray`.