Eugene C.
Eugene C.
Thank you for your reply. I'd totally be happy to contribute to this amazing project. I already started looking into the source code, and I was curious - is signature,...
Yes, for sure. I suppose I'll need to tweak this query object, right? https://github.com/ascribe/image-match/blob/master/image_match/elasticsearch_driver.py#L57
@rhsimplex I created a quick prototype locally, which doesn't use signatures and distances, and returns only those results where score is greater than 0. But there is one problem with...
Makes sense. Running more tests, though, makes me feel that relying on the score doesn't sound like a great idea. I indexed one image, then I searched for a bunch...
Ah, you are right. After comparing those images by looking at them, the one with distance `0.47` and score of `12.0` - is very similar to the indexed one. So...
Now I'm slightly confused 😕 I ran lots of tests with different images. I noticed that I always get elasticsearch scores, ranging 1 to 63. 63 is usually 1 to...
I could definitely do that, but I see one issue with that approach - let's say there is no match in the index for the image I'm searching by. However,...
Ok, I guess this discussion is going a little outside of the scope of that particular issue :) I can work on filing a PR, which will remove signatures from...
@rhsimplex I filed a PR. I kept `dist` for the non-elasticsearch implementation. I guess we'd also need to update the docs at some point.
> docs.count | store.size 7488880 | 31.2gb 8316821 | 11.9gb These are two indexes I have now. Second index is missing signatures. Pretty impressive results. However, I will keep looking...