TARDIS icon indicating copy to clipboard operation
TARDIS copied to clipboard

Add configurable brightness to lamps and add emissive textures

Open doctormysterio12 opened this issue 1 year ago • 16 comments

Describe the feature request

You mentioned wanting to add emissive textures to the pack, here's some lights I made. They all have an emissive texture, as well as a "cloister" texture. I thought maybe when a malfunction is true, instead of the lights flashing their regular colour, they switch to their cloister variant.

lights.zip

To fully capitalise on the emissive quality, a new control could be added with a slider (model attached below) that switches the lamps through light levels 2, 5, 10, and 15. The darker light levels would allow the "on" texture to be seen in the dark, showing the emissive texture of the roundel being rendered at full brightness.

Light Switch Slider image

As well as this, the lamp outside the 3D police boxes could be configured from inside using a 4 phase switch, the command could be Tardis update exterior_lamp. Each notch on the slider moves the lamp (light block) through light level 2,4,6, and 8, shift right clicking submits the light levels and changes the light level outside. This light block should spawn in at the configured light level when the box is solid during materialisation.

Exterior Lamp Slider image

console.zip

Both models have emissive textures to simulate LEDs on the panels, as well as an "off" texture for when the console is powered down so the LEDs appear to switch off.

The placement of both models is supposed to allow the placement of the control on the side of a halfslab.

I have a few more ideas for modelled console controls so I'd suggest setting up a "console" directory in the resource pack

Describe alternatives you've considered

Just throwing some ideas out there regarding lighting for you to test out, adding the lights alone as a proof of concept would be great

doctormysterio12 avatar Jan 27 '24 03:01 doctormysterio12

Crafting recipes?

eccentricdevotion avatar Feb 14 '24 23:02 eccentricdevotion

Copper for the base to form the plate, then lever and a couple of buttons each for the controls

Light Switch Slider - Warped Button, Lever, and Acacia Button Screenshot 2024-02-15 at 03 42 08

Exterior Lamp Slider - Lever, Bamboo button, Mangrove Button Screenshot 2024-02-15 at 03 37 21

doctormysterio12 avatar Feb 15 '24 03:02 doctormysterio12

https://github.com/eccentricdevotion/TARDIS/assets/1841924/60fe01cb-2c32-4fba-8634-a4b24186eee2

eccentricdevotion avatar Feb 15 '24 08:02 eccentricdevotion

Awesome! They look a bit big, I modelled them to fit on the side of a half slab so they could be used on the console

doctormysterio12 avatar Feb 15 '24 17:02 doctormysterio12

They are on half slabs... I haven't changed your model

eccentricdevotion avatar Feb 15 '24 18:02 eccentricdevotion

Oh wait I see there's slabs in front of the wall, I thought they were flush to the wall, my mistake

doctormysterio12 avatar Feb 15 '24 19:02 doctormysterio12

Had a play around with the new features

The lights are cool and add so much atmosphere! Great work they are really cool!

I have noticed, if you turn the console off and on, the lights go to full brightness - it would be nice if the config was remembered to set it back to where it was. Same with turning lights on/off

Can the names be hidden? The long name is quite obtrusive and it obscures the model. If not,could they be shortened to "Lights" and "Lamp" respectively

The exterior lamp, doesn't seem to work? There's no light at all outside since updating the control, tested turning the tardis off and on, or using the remote key to lock it and it doesn't flash any more

doctormysterio12 avatar Feb 25 '24 11:02 doctormysterio12

Fixed exterior lamp light level - build 2814

eccentricdevotion avatar Mar 08 '24 00:03 eccentricdevotion

The exterior lamp still doesn't seem to change with the controls, tested with a 2nd account externally and the lamp doesn't change brightness

The interior lights default to the darkest mode when being turned on

For the light levels, with them being logarithmic I think they need to be adjusted as the 4 options are a bit extreme. Keep dimmest at 2, but then maybe try 6 instead of 5 for the 2nd option, the other lighter options 2 are fine I think

TARDIS version: 5.4.0-b2814

doctormysterio12 avatar Mar 08 '24 23:03 doctormysterio12

Not seeing any issues with exterior light levels...

lamplevel0

lamplevel1

lamplevel2

lamplevel3

eccentricdevotion avatar Mar 09 '24 07:03 eccentricdevotion

This is what im seeing: https://github.com/eccentricdevotion/TARDIS/assets/123812066/00595870-0e7a-460e-bc9d-8e4392dce84e

doctormysterio12 avatar Mar 09 '24 11:03 doctormysterio12

Seems to be an issue with custom armour stand model presets...

eccentricdevotion avatar Mar 09 '24 21:03 eccentricdevotion

All looks good now! Love the addition thank you!

doctormysterio12 avatar Mar 15 '24 21:03 doctormysterio12

Seems to be possible to still use the controls when the TARDIS is off, the models dont update but the lights changes and then the controls are out of sync

doctormysterio12 avatar Mar 17 '24 17:03 doctormysterio12

I think you should still be able to use the controls, but the light levels shouldn't change until the power is restored

eccentricdevotion avatar Mar 19 '24 02:03 eccentricdevotion

After using the lights for a while, I think it would be good to add better definition to the controls as the difference in light levels is a lot. In #836 I've added new models with 8 states to compensate, it would be good to have light levels 15, 13, 12, 11, 9, 7, 5, and 3

doctormysterio12 avatar Mar 31 '24 17:03 doctormysterio12