ecamp3 icon indicating copy to clipboard operation
ecamp3 copied to clipboard

Frontend: start fixing lint warnings

Open BacLuc opened this issue 1 year ago • 2 comments

After

  • #5170 we can start with fixing the lint issues. See the single commits for further details.

BacLuc avatar Jun 09 '24 16:06 BacLuc

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

github-actions[bot] avatar Jun 15 '24 16:06 github-actions[bot]

I think I'll need to check each changed view. Maybe it would be sensible for me to refactor the unscoped components. It will probably still need some unscoped thematic css, and I'm not sure if we should keep this linter rule.

manuelmeister avatar Jun 21 '24 20:06 manuelmeister

I think I'll need to check each changed view. Maybe it would be sensible for me to refactor the unscoped components. It will probably still need some unscoped thematic css, and I'm not sure if we should keep this linter rule.

I would love it if we could restrict the css we write as much as possible. Then it would not be that hard to follow new standards.

I would not refactor the components now, but get as soon as possible to a state where a linter can at least tell us about some not ideal practises.

BacLuc avatar Jul 07 '24 15:07 BacLuc

And as far as i remember, vue3 did not like not scoped style tags, thus i would rather fix that now than with the big bang vue3 upgrade

BacLuc avatar Jul 07 '24 15:07 BacLuc

What i want to omit is the following:

We have it somewhat running, but we have thousands of these warnings:

image

and we don't know how we want to continue. Is this ok, is it not ok?

thus i want to remove as much issues as possible.

I don't know how you want to ensure that everything looks good again with refactoring. I would say we are faster if we just check if we can scope the css, and else we document, why it cannot be scoped.

This will also help with the refactoring.

BacLuc avatar Jul 08 '24 21:07 BacLuc