ecamp3 icon indicating copy to clipboard operation
ecamp3 copied to clipboard

Reduce number of JOINs in FilterByCampCollaboration and FiltersByContentNode

Open pmattmann opened this issue 1 year ago • 4 comments

This PR reduces the number of JOINs for FilterByCampCollaboration and FiltersByContentNode.

pmattmann avatar Feb 04 '24 14:02 pmattmann

Feature branch deployment ready!

Name Link
Deployment https://pr4616.ecamp3.ch/
Login [email protected] / test
Last deployed at Sun Feb 04 2024 17:37:00 GMT+0100
Latest commit 8a60673fb9457bdb0e3d25768af7ffc7bc4fe157
Latest deploy log https://github.com/ecamp/ecamp3/actions/runs/7775385258/job/21201348519
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

github-actions[bot] avatar Feb 04 '24 14:02 github-actions[bot]

I looked at the query plan against prod data, and your change does the following for big query when you hit http://localhost:3000/api/activities?camp=%2Fapi%2Fcamps%2F$CAMP_ID

image

image

On the first glance it seems to make sense, but in the end the effect seems minimal. What did you want to optimize?

Precomputing the camps of the users with a WITH does not help too, because the query optimizer already does this.

BacLuc avatar Feb 24 '24 17:02 BacLuc

Related to #4536

BacLuc avatar Feb 24 '24 17:02 BacLuc

@pmattmann I guess this is superseded by #5000 and can be closed, right?

usu avatar Apr 21 '24 05:04 usu

@pmattmann I guess this is superseded by #5000 and can be closed, right?

yes

pmattmann avatar Apr 30 '24 19:04 pmattmann