ecamp3 icon indicating copy to clipboard operation
ecamp3 copied to clipboard

ETextField: Input component refactor for $listeners

Open DeNic0la opened this issue 2 years ago • 1 comments

fixes #3893

I managed to fix the 'dont-autofocus-on-blur-if-autofocus'-issue with a custom VeeValidate interactionmode: Code here

https://github.com/ecamp/ecamp3/assets/57986114/6469be7c-cf50-498a-8ed6-21ccd3136a1c

i changed inputmode namings based on the HTML specs they now match the VeeValidate rules of decimal or numeric

I implemented a "," to "." replace on the API wrapper: decimal inputs can be entered with "," but will be loaded as "." this works somewhat: The write-to-object part works excellent, but the update from the store is not working at all - I have no idea why

https://github.com/ecamp/ecamp3/assets/57986114/c94b84af-10a4-4346-a516-0bc97c8a791d

the model modifier number doesn't support values like 324,33 if the value is not parseFloat() compatible it uses the string value. the "," support doesn't seem to work.

I also decided to hide the spin buttons since they would require a step value to be effective.

@manuelmeister what is the current goal for ETextField decimal/numeric support?

@ecampcore is the autofocus-validation-solution okey?

I haven't started with the tests since I don't think this is the final fix, code review is welcome tho. I don't understand why the ApiTextField doesn't update from the store.

DeNic0la avatar Oct 04 '23 14:10 DeNic0la

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

github-actions[bot] avatar Oct 04 '23 15:10 github-actions[bot]

I will close this PR for now, until someone continues. The PR is still referenced in the issue.

BacLuc avatar Apr 14 '24 10:04 BacLuc