ecamp3 icon indicating copy to clipboard operation
ecamp3 copied to clipboard

PrintDataController Entpoint draft

Open pmattmann opened this issue 2 years ago • 4 comments

Explicit EndPoint to load all required Data for print in ONE Request. Motivation: Make print a lot faster; reduce server-request loads.

The Group 'print' allows to control what information should be included.

On my Dev-Environment the HarryPotter-Camp loading all data takes 1.3seconds On PR-Deplayment the HarryPotter-Camp loading all data takes half a seconds

Check out the response: https://pr3612.ecamp3.ch/api/print/camp/05ce4b9836e9

pmattmann avatar Jul 01 '23 16:07 pmattmann

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

github-actions[bot] avatar Jul 01 '23 16:07 github-actions[bot]

If I understand correctly, we would need to adapt hal-json-vuex to be able to handle this response format, right? Could you instead output a fully HAL-compliant response? And could we have this documented in the OpenAPI Swagger Docs? (This needs to be done manually if you write a plain controller manually, which is why it is discouraged by API Platform)

carlobeltrame avatar Jul 06 '23 11:07 carlobeltrame

Core Meeting Dicision

  • Pseudo-Entität 'CampPrintData' mit DTO analog zu Invitation
  • Print Data-Load umbauen, nur diesen Endpoint laden

pmattmann avatar Aug 15 '23 20:08 pmattmann

This would probably need a test if we want to merge this, to notice when it breaks.

manuelmeister avatar Nov 03 '23 11:11 manuelmeister

Not needed right now

BacLuc avatar Apr 14 '24 00:04 BacLuc