ecamp3 icon indicating copy to clipboard operation
ecamp3 copied to clipboard

Improve saving indicator

Open manuelmeister opened this issue 2 years ago • 5 comments

Closes #3513

https://github.com/ecamp/ecamp3/assets/3001985/b9184cbd-ee9f-4d4c-b80d-44f5c63fba6d

manuelmeister avatar Jun 30 '23 17:06 manuelmeister

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

github-actions[bot] avatar Jun 30 '23 17:06 github-actions[bot]

Already way better! <3 And I like the icon.

Some Issues:

  • The Multi-Select-Dropdown for ActivityResponsible does not give any response at all (what was already the case before).
  • Dropdonw in general - the feedback now is only give by color - and it is event hard do distinguish between blu e and green

Additional thought: I guess users get used to autosave very quickly. Therefore the feedback could be even smaller.

pmattmann avatar Jul 01 '23 13:07 pmattmann

@usu the /controls site is outdated and not fully functioning anymore. (birthday and isAdmin are missing) I'm currently fixing a problem with parsing number inputs and tried the /controls page and was disappointed that it didn't work as expected. How can I fix these options (e.g. checkbox and date controls)?

manuelmeister avatar Sep 18 '23 16:09 manuelmeister

@usu the /controls site is outdated and not fully functioning anymore. (birthday and isAdmin are missing) I'm currently fixing a problem with parsing number inputs and tried the /controls page and was disappointed that it didn't work as expected. How can I fix these options (e.g. checkbox and date controls)?

They have been broken for quite some time. The controls for checkbox/switch/date have been added a long time ago (3 years or so) and back then, the user endpoint had this properties just for the sake of testing these input types. There are issues and discussion on this under https://github.com/ecamp/ecamp3/issues/1270 and https://github.com/ecamp/ecamp3/pull/673/files#r525987849.

Probably we should use other endpoints, if we want to test these input types with proper data. E.g. using the start date of the first period for the date picker? And for the checkbox/switch we could use $printYSLogoOnPicasso on the first camp.

usu avatar Sep 23 '23 06:09 usu

You need to merge devel again after #4136

BacLuc avatar Dec 17 '23 16:12 BacLuc

I would rather keep long running PR in an issue.

BacLuc avatar Apr 14 '24 10:04 BacLuc