ecamp3 icon indicating copy to clipboard operation
ecamp3 copied to clipboard

Deploy alpha (test fast-forward worklow)

Open usu opened this issue 3 years ago • 13 comments

usu avatar Oct 15 '22 04:10 usu

/fast-forward

usu avatar Oct 15 '22 04:10 usu

/fast-forward

Hmm, https://github.com/ecamp/ecamp3/actions/runs/3254469934/jobs/5342760618 says "This job was skipped", which would mean something in the if-clause already failed. @BacLuc any idea what failed?

usu avatar Oct 15 '22 05:10 usu

/fast-forward

usu avatar Oct 16 '22 05:10 usu

Failed! Cannot do fast forward!

github-actions[bot] avatar Oct 16 '22 05:10 github-actions[bot]

Failed! Cannot do fast forward!

Nice, now it does what it should do: https://github.com/ecamp/ecamp3/actions/runs/3258333752/jobs/5350337002

RequestError [HttpError]: At least 1 approving review is required by reviewers with write access. You're not authorized to push to this branch.

usu avatar Oct 16 '22 05:10 usu

/fast-forward

carlobeltrame avatar Oct 16 '22 10:10 carlobeltrame

Failed! Cannot do fast forward!

github-actions[bot] avatar Oct 16 '22 10:10 github-actions[bot]

Something still isn't right:

RequestError [HttpError]: You're not authorized to push to this branch.

carlobeltrame avatar Oct 16 '22 10:10 carlobeltrame

/fast-forward

carlobeltrame avatar Oct 16 '22 10:10 carlobeltrame

Failed! Cannot do fast forward!

github-actions[bot] avatar Oct 16 '22 10:10 github-actions[bot]

/fast-forward

carlobeltrame avatar Oct 16 '22 10:10 carlobeltrame

Failed! Cannot do fast forward!

github-actions[bot] avatar Oct 16 '22 10:10 github-actions[bot]

I tried adjusting the branch protection rules to allow the ecamp3 core team to push to this branch, but it doesn't work because we pass GITHUB_TOKEN to the workflow. This token represents a user which is not selectable in the branch protection rule exceptions [1], and if it were that would apparently be a security hole. We could instead create a service token for @ecampcore and pass that to the action.

carlobeltrame avatar Oct 16 '22 11:10 carlobeltrame

/fast-forward

carlobeltrame avatar Nov 02 '22 08:11 carlobeltrame

The PR mergeable_state needs to be clean, was: blocked

github-actions[bot] avatar Nov 02 '22 08:11 github-actions[bot]

/fast-forward

carlobeltrame avatar Nov 02 '22 10:11 carlobeltrame

The PR mergeable_state needs to be clean, was: blocked

github-actions[bot] avatar Nov 02 '22 10:11 github-actions[bot]

When I query the API myself using a new personal API token on my account, I get "mergeable_state": "unstable", which would be fine (we should actually allow that, because it indicates that only non-required status checks such as Coveralls failed). That also matches with what the GitHub UI displays to me. I don't understand why this workflow says it's "blocked"...

carlobeltrame avatar Nov 02 '22 10:11 carlobeltrame

The PR mergeable_state needs to be clean, was: blocked

github-actions[bot] avatar Nov 02 '22 12:11 github-actions[bot]

/fast-forward

usu avatar Nov 02 '22 15:11 usu

The PR mergeable_state needs to be clean, was: blocked

github-actions[bot] avatar Nov 02 '22 15:11 github-actions[bot]