ecamp3 icon indicating copy to clipboard operation
ecamp3 copied to clipboard

Follow up to Create materiallist for collaboration

Open BacLuc opened this issue 3 years ago • 2 comments

Follow up to #2452

  • [ ] Set the materiallist to the name of the collaborator when the campcollaboration is deleted. https://github.com/ecamp/ecamp3/pull/2452#discussion_r832152215 and follow up https://github.com/ecamp/ecamp3/pull/2452#discussion_r832505798 @BacLuc : If 2 people have the same name, they cannot change the name of the campcollaboration that they can be distinguished. Alternative: return null and translate the fallback in the frontend.
  • [ ] Eventually remove the flush in CampCollaborationPersister https://github.com/ecamp/ecamp3/pull/2452#discussion_r832504118 (To be discussed)
  • [x] When cloning a camp (Either from a prototype or from an existing camp), (https://github.com/ecamp/ecamp3/pull/2452#discussion_r837314111)
    1. should the reference Materiallist->campCollaboration be preserved,
    2. null written into the materiallist name
    3. the name of the collaborator be copied?
    4. New: the material list not be copied? (this is implemented now)

BacLuc avatar Apr 10 '22 11:04 BacLuc

What is still open in this issue?

carlobeltrame avatar Sep 05 '25 16:09 carlobeltrame

The first 2 points: Name of the CampCollaboration is not yet set to the name of the Collaborator when the collaboration is deleted. Flush is still there: https://github.com/ecamp/ecamp3/blob/7407b7f4362e6c6d5da6276780b603a36a5345e1/api/src/State/CampCollaborationCreateProcessor.php#L70

BacLuc avatar Sep 05 '25 18:09 BacLuc