taquito icon indicating copy to clipboard operation
taquito copied to clipboard

chore: remove signature.json files

Open ac10n opened this issue 1 year ago • 5 comments

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • [ ] Your code builds cleanly without any errors or warnings
  • [ ] You have run the linter against the changes
  • [ ] You have added unit tests (if relevant/appropriate)
  • [ ] You have added integration tests (if relevant/appropriate)
  • [ ] All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • [ ] You have added or updated corresponding documentation
  • [ ] If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • [ ] You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • [ ] You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for inclusion in the Release Notes for the next Taquito release.

ac10n avatar Aug 25 '23 21:08 ac10n

Deploy Preview for taquito-test-dapp ready!

Name Link
Latest commit 51af38cec0d66971a93e8efdba04ae90ad0d8809
Latest deploy log https://app.netlify.com/sites/taquito-test-dapp/deploys/65301aea1eb254000848f42b
Deploy Preview https://deploy-preview-2623--taquito-test-dapp.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 25 '23 21:08 netlify[bot]

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

github-actions[bot] avatar Aug 25 '23 21:08 github-actions[bot]

A new deploy preview is available on Netlify at https://72690a0--tezostaquito.netlify.app

github-actions[bot] avatar Aug 25 '23 22:08 github-actions[bot]

merge conflicts need to be fix and the mentioning of signing packages in readme also need to be removed https://github.com/ecadlabs/taquito#releases

hui-an-yang avatar Oct 17 '23 15:10 hui-an-yang

merge conflicts need to be fix and the mentioning of signing packages in readme also need to be removed https://github.com/ecadlabs/taquito#releases

Nice catch. We should have removed that long ago, when we stopped signing packages. The fact that no one has complained also supports Jev's point that signing does not provide a lot of value.

ac10n avatar Oct 18 '23 17:10 ac10n