ttrpg-convert-cli icon indicating copy to clipboard operation
ttrpg-convert-cli copied to clipboard

🐛✨ Create reference for weapon mastery properties from XPHB

Open jboehm77 opened this issue 9 months ago • 2 comments

Describe the bug

Files linking to the weapon mastery note have broken links. They try to link to rules/variant-rules/weapon-mastery-properties-xphb.md when the tool instead generates its own file that collects that information in rules/item-mastery.md. The links should be updated in the respective notes that attempt to reference that file. Example attached below.

barbarian-xphb.md

Expected Behavior

Files that attempt to reference the list of weapon masteries should link to rules/item-mastery.md instead of rules/variant-rules/weapon-mastery-properties-xphb.md.

TTRPG CLI Version

3.0.1

Which Operating Systems have you experienced this on?

  • [ ] Android
  • [ ] iPhone/iPad
  • [ ] Linux
  • [ ] macOS
  • [x] Windows

jboehm77 avatar Feb 03 '25 17:02 jboehm77

After 70fec38 it looks like the links have been replaced with formatted text instead. Good enough for me unless this was a placeholder.

jboehm77 avatar Mar 24 '25 01:03 jboehm77

So this one is tricky. I did fix it so that if the link fails to resolve, it just puts the display text in (which is what always should have happened.. see the laundry list of borked links I fixed because my link verifier was broken.. 🤦 )

This one, in particular, is difficult.. the referenced variant rule is generated as a reference from the book content ahead of time. So I would have to add an additional/early scanning step to see if the book is included, and then go rummaging for ...

Non-trivial.

ebullient avatar Mar 24 '25 13:03 ebullient