ttrpg-convert-cli icon indicating copy to clipboard operation
ttrpg-convert-cli copied to clipboard

5e missing Ability in FEATS conversion

Open RoyDJ84 opened this issue 1 year ago • 4 comments

when convertitn all ability fields from json are not converted to md

some feats have a +x value for some ability scores, in the conversion should be ported

the ability score increment is omitted

example: Actor   Skilled at mimicry and dramatics, you gain the following benefits:

Increase your Charisma score by 1, to a maximum of 20.

You have advantage on Charisma (Deception) and Charisma (Performance) checks when trying to pass yourself off as a different person.

You can mimic the speech of another person or the sounds made by other creatures. You must have heard the person speaking, or heard the creature make the sound, for at least 1 minute. A successful Wisdom (Insight) check contested by your Charisma (Deception) check allows a listener to determine that the effect is faked.

what i get in md after conversion

Actor Skilled at mimicry and dramatics, you gain the following benefits:

  • You have advantage on Charisma (Deception) and Charisma (Performance) checks when trying to pass yourself off as a different person.
  • You can mimic the speech of another person or the sounds made by other creatures. You must have heard the person speaking, or heard the creature make the sound, for at least 1 minute. A successful Wisdom (Insight) check contested by your Charisma (Deception) check allows a listener to determine that the effect is faked.

thanks for all you do for all of us.

RoyDJ84 avatar Dec 16 '23 11:12 RoyDJ84

See https://github.com/5etools-mirror-2/5etools-mirror-2.github.io/blob/5e0cc455b990b2fe1d84cb0def30877bd101e773/js/render.js#L5268

revilowaldow avatar Apr 10 '24 10:04 revilowaldow

See https://github.com/5etools-mirror-2/5etools-mirror-2.github.io/blob/5e0cc455b990b2fe1d84cb0def30877bd101e773/js/render.js#L5268

This link is no longer available unfortunately. I have the same issue with Ability in 2014 Feats. Did your link contain a fix? I've looked into the attributes and edited the feat template, but I'm unable to get data like 5eTools with Ability scores.

Squidlez avatar Oct 07 '24 17:10 Squidlez

No fix, but it's the method for the converter tool to copy as the text is added automatically from the data but that's just not implemented for this markdown it would seem.

New link:

https://github.com/5etools-mirror-3/5etools-src/blob/b8ec6e04ec1a8905c789de857ca133ed411031a0/js/render.js#L5890

revilowaldow avatar Oct 07 '24 21:10 revilowaldow

not yet. it's been on the list for awhile.

ebullient avatar Oct 08 '24 17:10 ebullient

Issue fixed by #641 @ebullient?

jboehm77 avatar Mar 29 '25 01:03 jboehm77

Yes, I think so.

ebullient avatar Apr 29 '25 10:04 ebullient