obsidian-task-collector icon indicating copy to clipboard operation
obsidian-task-collector copied to clipboard

Published 20 hours ago • verified publisher icon ebullient

Potential Issue on Collection

Open GeorgeGo opened this issue 2 years ago • 9 comments

I'm not sure if this is or isn't intended behavior and I wasn't sure of the best method to get feedback.

When performing Collect Tasks with the Remove Checkbox option enabled, items that are subtasks don't have their checkboxes removed.

For example,

  • [x] A
    • [x] B
    • [x] C

Becomes,

Log

  • A
    • [x] B
    • [x] C

I'm using version 1.0.5 of Task Collector with a fresh vault using the default settings enabling Remove Checkboxes.

GeorgeGo avatar Feb 07 '23 23:02 GeorgeGo

This is a perfect method. Thanks for raising the issue! I can add some tests and fix this to ensure that happens.. oversight on my part. ;)

ebullient avatar Feb 08 '23 12:02 ebullient

I'm fine writing the fix for it. I just wanted to confirm that it was an issue first.

GeorgeGo avatar Feb 09 '23 00:02 GeorgeGo

yes! that would be super helpful. You know the drill with tests. ;)

ebullient avatar Feb 09 '23 00:02 ebullient

I'm including this as a note for myself but I also noticed an issue where incomplete tasks with complete subtasks would get incorrectly collected.

GeorgeGo avatar Feb 20 '23 21:02 GeorgeGo

I have some tests for incomplete parents w/ completed kids. I'm surprised that one is happening.. Relationship/collection behavior for tasks w/ subtasks is... interesting.

ebullient avatar Feb 20 '23 21:02 ebullient

I’ll have to double check the behavior and make sure that it’s consistent/not due to something else.

I’ll update the test cases once I’ve better defined what all is going on.

I’m still planning on addressing the main collect tasks issue this issue addresses, just been bogged down with work.

On Feb 20, 2023, at 1:47 PM, Erin Schnabel @.***> wrote:

I have some tests for incomplete parents w/ completed kids. I'm surprised that one is happening.. Relationship/collection behavior for tasks w/ subtasks is... interesting.

— Reply to this email directly, view it on GitHub https://github.com/ebullient/obsidian-task-collector/issues/132#issuecomment-1437587925, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPKFMJDOX77OSXI7IWULGTWYPRAZANCNFSM6AAAAAAUUR7LXQ. You are receiving this because you authored the thread.

GeorgeGo avatar Feb 20 '23 21:02 GeorgeGo

Also is it intended for the 'Task Mark' operation to overwrite the time information on a task that already has that specific mark?

GeorgeGo avatar Feb 20 '23 22:02 GeorgeGo

yes.

I don't use the remove checkbox function because I use regex pipeline plugin for that. For me the bigger/first issue is making sure items / sub-items are handled properly. Second issue is remove checkbox being applied correctly w/in completion areas (according to existing rules and behavior.. shouldn't change the marking).

Extensive tests here: https://github.com/ebullient/obsidian-task-collector/blob/main/test/generatedRegExp.test.ts to ensure previous marks are changed when the task is marked again..

ebullient avatar Feb 21 '23 14:02 ebullient

Also is it intended for the 'Task Mark' operation to overwrite the time information on a task that already has that specific mark?

I missed that nuance. We could probably check to see if the mark is the same, and skip it if so.

I've added that in this commit: c5b6ba00f7c42f7f11893a84b909bab45d3e041f https://github.com/ebullient/obsidian-task-collector/blob/cb5c5e00d4d23856bc4f8eba86bcf1d24c1815dc/src/taskcollector-TaskCollector.ts#L274

ebullient avatar Apr 15 '23 22:04 ebullient