ebucoreplus icon indicating copy to clipboard operation
ebucoreplus copied to clipboard

299 refactoring renaming property cluster 01

Open alexander-schulze opened this issue 1 year ago • 1 comments

This pull request includes the renaming of ten object properties.

  • appliesOutOf to hasTerritoryExcludes
  • appliesTo to hasTerritoryIncludes
  • applyTo to hasTerritoryIncludes
  • clonedTo to hasClone
  • isClonedFrom to isCloneOf
  • dubbedTo to hasDub
  • isDubbedFrom to isDubOf
  • isCoveredBy to hasRights
  • isAgent to hasRelatedAgent
  • isAnimalGroom to hasAnimalGroom

Reviewers

  • @JuergenGrupp
  • @aro-max

alexander-schulze avatar May 13 '24 08:05 alexander-schulze

I have 3 improvements to this pull request:

  1. I think I have spotted an error in our renaming plan of applyTo: applyTo is currently only used here: Rights applyTo Asset. The wording seemed strange at first, because of the plural "apply" instead of "applies". That is why we proposed this change to hasTerritoryIncludes. But the meaning would change with hasTerritoryIncludeand the grammar of applyTo is fully correct and expresses exactly what our intention is. My conclusion: stick with applyTo and do not rename it.

  2. There is another class to use applyTo with: PublicationEvent. My conclusion: add the following restriction to the ontology: "Rights applyTo PublicationEvent.

  3. This opens up the opportunity to make "applyTo" and "isCoveredBy" inverse properties. My conclusion: add the rule applyTo isInverseOf isCoveredBy

Please comment!

JuergenGrupp avatar May 13 '24 14:05 JuergenGrupp

Yes @JuergenGrupp, I agree. @aro-max do you agree with these changes so I can proceed with making the updates?

alexander-schulze avatar May 17 '24 09:05 alexander-schulze

Here are the latest changes made:

  1. Reinitialized the applyTo object property instead of renaming it to hasTerritoryIncludes.
  2. Removed the Rights hasTerritoryIncludes Asset restriction and replaced it with the Rights applyTo Asset restriction.
  3. Added a new restriction: Rights applyTo PublicationEvent.
  4. Added applyTo object property as the inverse of the isCoveredBy object property, which is renamed to hasRights.

alexander-schulze avatar May 22 '24 05:05 alexander-schulze

@JuergenGrupp, can you please review the latest changes and merge it?

alexander-schulze avatar May 22 '24 07:05 alexander-schulze

Cleaned up mixed-in property values for rdfs:label and dcterms:description from hasRelatedAgent, ensuring only 3 values for supported languages, and removed owl:IrreflexiveProperty from hasRelatedAgent.

alexander-schulze avatar May 22 '24 10:05 alexander-schulze