benchmarkstt icon indicating copy to clipboard operation
benchmarkstt copied to clipboard

Published 20 hours ago • verified publisher icon ebu

Code coverage reports and goals

Open MikeSmithEU opened this issue 6 years ago • 3 comments

(related to #14 )

What reporting strategy do we want to use for this, looking for more input and volunteers to take this on.

  • What percentage of code coverage would we find acceptable (assuming 100% is the gold standard that we will strive for, yet may not achieve)?
  • Do we only merge Pull Requests if we have e.g. 90%+ code coverage?
  • Should this be our first next goal for the existing codebase before we continue with extra development?

MikeSmithEU avatar Feb 07 '19 17:02 MikeSmithEU

Code coverage check is now implemented in PR2, we are at a decent starting point of 54%. I propose for now to not accept PR’s if it dips below 50%. As more unit tests are added we should keep increasing that percentage.

MikeSmithEU avatar Apr 10 '19 07:04 MikeSmithEU

I've updated #48 PR2 and now we are at 87% coverage. Propose to set new minimum to 80% for now.

MikeSmithEU avatar Apr 14 '19 08:04 MikeSmithEU

Code coverage: target of 90% for all releases. Aiming towards 100%. Coverage excludes out of scope components such as the JSON RPC Explorer.

Todo before closing this tickets: add this decision to the documentation and the contribution guidelines.

EyalLavi avatar May 21 '19 13:05 EyalLavi