canmatrix icon indicating copy to clipboard operation
canmatrix copied to clipboard

Buttons for Folding/Unfolding Messages in Excel desappear at development branch compared to master

Open djdesant opened this issue 10 months ago • 6 comments

master development

The file is converted from dbc to xlsx format. The buttons 1/2 for folding/unfolding are very useful feature for grouping the message view. It would be nice to have it in the development branch too.

djdesant avatar Apr 10 '24 14:04 djdesant

Hi @djdesant

Thanks for reporting this Bug! Gonna have a Look on it

ebroecker avatar Apr 10 '24 14:04 ebroecker

Thanks for quick response @ebroecker, i guess the replacement of xlsxwriter by openpyxl should be the cause of this issue.

djdesant avatar Apr 10 '24 15:04 djdesant

hi @djdesant

yes indeed, the old code for folding is even in the comments :-) But I totally forgot about it

ebroecker avatar Apr 11 '24 07:04 ebroecker

should be fixed in branch issue780_fold_xlsx

You should be able to test:

pip install git+https://github.com/ebroecker/canmatrix/tree/issue780_fold_xlsx

ebroecker avatar Apr 11 '24 13:04 ebroecker

should be fixed in branch issue780_fold_xlsx

You should be able to test:

pip install git+https://github.com/ebroecker/canmatrix/tree/issue780_fold_xlsx

I have tested the bugfix of #780 successfully. The right package install syntax for me was: pip install git+https://github.com/ebroecker/canmatrix.git@issue780_fold_xlsx

Fixing of #778 is still needed for continuing the proper work on DBC-converting.

Thanks in advance.

djdesant avatar Apr 11 '24 14:04 djdesant

@ebroecker, when are you planning to merge the current branch into master ?

djdesant avatar Apr 21 '24 19:04 djdesant