canmatrix icon indicating copy to clipboard operation
canmatrix copied to clipboard

JSON conversion - add values

Open gesc31 opened this issue 7 years ago • 3 comments

Hi, I used canconvert to convert a dbc file to a json file with jsonAll option but noticed that the values where not exported. Could you please modify the dump function in cmjson.py to add "values": signal.values, in signalDict by default? Thanks

gesc31 avatar Feb 16 '18 15:02 gesc31

Add even more information to --jsonAll Goal should be to add all information, so that writing to json and reading again is loseless.

ebroecker avatar Apr 06 '18 08:04 ebroecker

I have made a fix that add the Value Tables/Enumerations Dict to the JSON output file in Seneda/canmatrix/tree/AddEnumstoJSON. But I will hold off on doing a PR until i see if my existsing PR #475 gets accepted or not so that I can rebase my branch before submitting it.

Pull Request

Seneda avatar Apr 24 '20 13:04 Seneda

can this issue be closed?

ebroecker avatar May 27 '22 21:05 ebroecker

open new small tickets for missing attributes in json format

ebroecker avatar Jan 23 '23 14:01 ebroecker

https://github.com/ebroecker/canmatrix/commit/32fb4932b6d9124932ca8fed7c0b2c7caea6edf0

ebroecker avatar Jan 25 '23 16:01 ebroecker