Emmanuel Bourg comments

Results 237 comments of


                                            Emmanuel Bourg

Support AWS KMS Key Aliases

@tresf Thank you for the feedback, I think I can close the issue now.

Pathname with spaces errors as if not quoted on Cygwin

> many thanks for your efforts making jsign as an alternative to the pain known as signtool! You're welcome :) > I seem to have come across an issue where...

Pathname with spaces errors as if not quoted on Cygwin

@drew-512 Did any of the suggestions work?

Pathname with spaces errors as if not quoted on Cygwin

I'm unable to reproduce the issue. Do you think you could share a minimal script triggering the error?

Pathname with spaces errors as if not quoted on Cygwin

Did you try to replace `$TARGET_FILE` with `$1` to see if `cygpath` is causing this issue?

Pathname with spaces errors as if not quoted on Cygwin

@tresf Good catch, thank you. Do you want to contribute a PR for `jsign.cmd`?

Pathname with spaces errors as if not quoted on Cygwin

@drew-512 Thank you for the feedback! Closing the issue now.

Missing APIs to write content to PE signature entries in Jsign 7.0

The API can be modified if necessary, but have you checked out the new [tagging](https://ebourg.github.io/jsign/#tagging) feature of Jsign 7.0? You can now embed arbitrary data into the signature without invalidating...

Missing APIs to write content to PE signature entries in Jsign 7.0

The API is in the SignerHelper class but it's package private. I plan to make this class public at some point, but in the meantime you can simply call JsignCLI...

Missing APIs to write content to PE signature entries in Jsign 7.0

What do you dislike? If SignerHelper was public it wouldn't be that different: ``` SignerHelper helper = new SignerHelper(); helper.value("userid:1234-ABCD-5678-EFGH").tag(signedFile) ```