r2modmanPlus icon indicating copy to clipboard operation
r2modmanPlus copied to clipboard

Option to use Flatpaks under Linux

Open RossBrunton opened this issue 1 year ago • 4 comments

This adds a configuration setting "linuxUseFlatpak" which controls whether Steam should be launched as a Flatpak or not. By default this is detected automatically based on the path, but an option in the settings can override the behaviour.

If this option is enabled, we first check if we are able to read from our config directory. If not, we display an error and ask the user to give us permission. If we do, then we launch Steam through flatpak rather than the binary directly.

Closes: #1144, #1051

RossBrunton avatar Oct 02 '24 23:10 RossBrunton

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 02 '24 23:10 CLAassistant

So I did all this work, and then decided to check if someone else had done it, and it seems both @wash2 ( https://github.com/ebkr/r2modmanPlus/pull/798 ) and @PedroVH ( https://github.com/ebkr/r2modmanPlus/pull/1064 ) have done this earlier. Guess I should have checked first.

Anyway, I think hopefully this should be more sophisticated, since it doesn't assume any hardcoded paths, allows the user to configure things and shows up an error if it isn't configured correctly.

Also, full disclosure, I've only tested this on Lethal Company, and I'm super unfamiliar with typescript.

RossBrunton avatar Oct 02 '24 23:10 RossBrunton

Is there anything blocking this from being accepted?

RossBrunton avatar Feb 18 '25 22:02 RossBrunton

Why has this not been merged yet?

gegoxaren avatar Apr 26 '25 20:04 gegoxaren